[bun:sqlite] Support sqlite3_file_control
, better closing behavior, implement Disposable
#10262
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
You can now manage the lifetime of a
Database
instance inbun:sqlite
via theusing
keyword:Database#fileControl
lets you use thesqlite3_file_control
APIFor example:
Automatically closing databases when the
Database
object GC'd was not implemented correctly before (bun would only automatically close the database before process exit). This has now been fixeddatabase.close(true)
will now throw an error if the database has any pending resources associated with it.Fixes #2537
How did you verify your code works?
Tests